[Bug 1249047] Review Request: jaxb2-basics-annotate - Plugin that add arbitrary annotations to JAXB classes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1249047



--- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Jonny Heggheim from comment #1)
> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated". 5 files have unknown license.
> jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/
> plugin/annotate/AnnotatePlugin.java
> jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/
> plugin/annotate/AnnotatingArrayValueVisitor.java
> jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/
> plugin/annotate/AnnotatingSingleValueVisitor.java
> jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/
> plugin/annotate/AnnotatingVisitor.java
> jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/
> plugin/annotate/Annotator.java
> 
> Please contact upstream to clarify licensing. Best if they put proper
> license header and release new version.

Done https://github.com/highsource/jaxb2-annotate-plugin/issues/12

> This is my first review, here are some small extra comments:
> > find -name "*.class" -print -delete
> Not needed, upstream does not include .class files
> 
> > find -name "*.jar" -print -delete
> Not needed, upstream does not include .jar files
> 
> > rm -r plugin/src/test/java/org/jvnet/jaxb2_commons/plugin/annotate/tests/RunPlugin.java
> -r flag is not needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]