[Bug 1251834] Review Request: python-rackspace-auth-openstack - Rackspace authentication for openstack clients

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1251834



--- Comment #1 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
Note that macros are evaluated even in comments.
You probably do not want that.

Use macros consistently. I.e. %{buildroot} instead of $RPM_BUILD_ROOT.

Why is there 
  %doc
withouth anything specified?

Directory 
  %{python2_sitelib}/%{modname}
is not owned. You should own it.

You may use macro
  %py2_install
see 
  https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]