[Bug 673585] Review Request: perl-Apache-Htgroup - Manage Apache htgroup files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=673585



--- Comment #15 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Here is my review for your -3 release srpm 

1)I see you have used Buildroot tag which is also become optional and not
needed. Can you remove it and upload again spec and srpm? No need to bump the
release tag. Also, fedora-review output review.txt showed mismatch of spec
given by spec url and spec file inside srpm as

Diff spec file in url and in SRPM
---------------------------------
--- /home/parag/673585-perl-Apache-Htgroup/srpm/perl-Apache-Htgroup.spec       
2015-08-18 21:51:58.536356400 +0530
+++
/home/parag/673585-perl-Apache-Htgroup/srpm-unpacked/perl-Apache-Htgroup.spec  
    2015-08-18 20:38:27.000000000 +0530
@@ -35,6 +35,6 @@

 %files
-%doc README
 %license LICENSE
+%doc README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
@@ -42,5 +42,5 @@
 %changelog
 * Tue Aug 18 2015 Steven Hadfield <hadfieldster@xxxxxxxxx> 1.23-3
-- RPM spec cleanup
+- RPM spec fixes

 * Fri Jul 6 2012 Steven Hadfield <StevenHadfield@xxxxxxxx> 1.23-2


2) It is okay if there is no response from upstream on fixing fsf address
issue.

3) Start reviewing other people's packages and once you did full package review
like I did for you in comment#11 here, post that review link in this bugzilla
to let me know that you are reviewing and your reviews are good where you have
pointed some issues with how to fix them.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]