[Bug 1254221] Review Request: python-networking-vmware-nsx - VMware OpenStack Neutron driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1254221



--- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
(In reply to Ihar Hrachyshka from comment #3)
> - for objects.inv violations, I don't believe I should change anything since
> it's a file generated by sphinx;

*nod*

> - for lack of manual page, as Alan already replied, I am not required to
> provide one, and upstream (openstack) won't provide any of those ever, so no
> big reason to notify them.

The referenced guidelines say:
If some man pages are absent, packagers should work with upstream to add them.
So you should at least report it. And since you work as neutron upstream too,
you may want to create it as well and make world better.
But yeah, this is SHOULD item and I will not block the review on this.

One more thing:
> %global vendor VMware
This have the same efect as:
Vendor: VMware

And result in:
pm -qpi
/home/msuchy/1254221-python-networking-vmware-nsx/results/python-networking-vmware-nsx-0.0.1-1.64cc70f.fc23.noarch.rpm
Name        : python-networking-vmware-nsx
Version     : 0.0.1
Release     : 1.64cc70f.fc23
Architecture: noarch
Install Date: (not installed)
Group       : Unspecified
Size        : 3148157
License     : ASL 2.0
Signature   : (none)
Source RPM  : python-networking-vmware-nsx-0.0.1-1.64cc70f.fc23.src.rpm
Build Date  : Út 18. srpen 2015, 17:28:55 CEST
Build Host  : dri.brq.redhat.com
Relocations : (not relocatable)
Vendor      : VMware
^^^^^^^^^^^^^^^^^^^^^^^^^  NOTE HERE

URL         : https://pypi.python.org/pypi/vmware-nsx
Summary     : VMware OpenStack Neutron driver
Description :
This package contains VMware networking driver for OpenStack Neutron.


Which is probably not what you intended. And usage of this tag is discouraged.
This can be easily avoided by using different name for this variable. E.g.
%drv_vendor or similar.
As this is easy change, you can alter it before uploading to dist-git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]