[Bug 1246903] Review Request: gnome-shell-extension-openweather - an extension to display weather information from many locations in the world

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1246903



--- Comment #8 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
> Release:        0.1.%(date +%Y%m%d).%{checkout}%{?dist}

The extra dot before "git" is slightly off the guidelines for snapshot
packages:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> fedora-review finds no issues, except the issue with owning
> directories owned by other packages. But this is a must for
> gnome-shell-extensions, that do not require gnome-shell-extensions-common.
> They can be the only package that uses these directories and
> therefore they have to own them.

In case of doubt, better ask for feedback on packaging@ list.

In my opinion, "Requires: gnome-shell-extension-common" would be the way to go.

The gnome-shell-extension-common package description tells that it is also sort
of a -filesystem package (similar to the main purpose the hicolor-icon-theme
package serves nowadays):

  $ rpm -qi gnome-shell-extension-common|tail  -2
  optional functionality to GNOME Shell. Common files and directories
  needed by extensions are provided here.

The yellow box here covers -filesystem packages:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function


> %postun
> %posttrans

News for Rawhide. File triggers:
https://lists.fedoraproject.org/pipermail/desktop/2015-August/012685.html

[...]

What else?

As I don't call myself an expert on GNOME Shell extensions, let me ask: What is
the standard way to find these packages in the Fedora package collection. In
gnome-tweak-tool I may only visit the web site to install more. And in GNOME
Software, I cannot find them either (likely because of no appdata files in
those packages).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]