[Bug 1245889] Review Request: python-pymssql - Microsoft SQL Server adapter for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1245889



--- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
I believe there should be no blank line after %description.

Please use macros consistently
I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}.
%{optflags} instead of $RPM_OPT_FLAGS

rm -rf $RPM_BUILD_ROOT
is not needed unless you target el5

%if 0%{?fedora}
%bcond_without python3
%else
%bcond_with python3
%endif

What is %bcond_without?
This evaluate on my machine to:

%if 0%{?fedora}
%else
%endif

which raise
error: /tmp/1245889-python-pymssql/srpm/python-pymssql.spec:6: bad %if
condition


Why do you use simple
  %doc
in %files section without anything specified after that. Then you do not need
to use it at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]