[Bug 970436] Review Request: mingw-kde-filesystem - KDE filesystem layout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970436



--- Comment #1 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
Please use macros consistently
I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}.

%defattr(-,root,root,-)
This is not needed since rpm 4.2

mingw-kde-filesystem.spec:182: W: mixed-use-of-spaces-and-tabs (spaces: line
64, tab: line 182)

> # teamnames (locales) borrowed from kde-i18n packaging
> Source1: teamnames

Do you use it somewhere. It seems to me, that it is not used at all.

The same goes for:
> Source2: macros.kde4

And then you are creating dynamically
cat >$RPM_BUILD_ROOT%{mingw32_sysconfdir}/rpm/macros.kde4<<EOF

So I would suggest to put your content in macros.kde4 which you include as
SourceX and the just do:
cp -a macros.kde4 %{buildroot}%{mingw32_sysconfdir}/rpm/macros.kde4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]