[Bug 1128337] Review Request: libnsgif - Decoding library for the GIF image file format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128337

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?



--- Comment #8 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #7)
> > [-]: Package contains the mandatory BuildRequires and Requires:.
> >      Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
> >      echo $version)) missing?
> 
> > libnsgif-devel.x86_64: W: doc-file-dependency /usr/share/doc/libnsgif-devel/examples/disassemble_gif.pl perl(strict)
> > libnsgif-devel.x86_64: W: doc-file-dependency /usr/share/doc/libnsgif-devel/examples/disassemble_gif.pl perl(warnings)
> > libnsgif-devel.x86_64: W: doc-file-dependency /usr/share/doc/libnsgif-devel/examples/disassemble_gif.pl /usr/bin/perl
> 
> > libnsgif-devel (rpmlib, GLIBC filtered):
> >     /usr/bin/perl
> 
> This is about what David Tardon has pointed out in comment 2.
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> 
> | Files marked as documentation must not cause the package to pull in
> | more dependencies than it would without the documentation. One simple
> | way to ensure this in most cases is to remove all executable permissions
> | from files in %_pkgdocdir.

He obviously pasted the initial review log, I've verified that my chmod -x
fixes the problem.

$ rpmlint -v ./libnsgif-devel-0.1.2-1.fc24.i686.rpm 
libnsgif-devel.i686: I: checking
libnsgif-devel.i686: I: checking-url
http://www.netsurf-browser.org/projects/libnsgif/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]