[Bug 1174974] Review Request: python-mox3 - Mock object framework for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1174974



--- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Alan Pevec from comment #14)
> > scripts check whether the bug-reporter
> 
> So we're slaves to the scripts?!
> No wonder we're turning away potential contributors with such artificial
> obstacles :(
I think everybody agrees that this is an unnecessary obstacle. At last Flock
somebody (it might have been sgallagh, I don't remember for sure) said that
they added that check and it could be removed. But it's there atm.

Like I said, I'll review the new ticket, so it's just a question of filling out
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=fedora-review
and copying comment #12. I think that should hardly matter compared to the
amount of work required for a package.

> > - you removed the removal of egg-info in %prep. It is customary to do remove
> > it in %prep to be sure that no stale info ends up in the binary package.
> 
> That was a misguided custom, python guidelines has been clarified in
> https://fedorahosted.org/fpc/ticket/488 (relevant here is point 5.)
> 
> Egg metadata from upstream should be preserved, in some cases ( e.g.
> packages using PBR.) you can't reconstruct it completely when building from
> a sdist tarball.
OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]