[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #13 from Marcin Haba <marcin.haba@xxxxxxxxx> ---
Hello,

(In reply to Dave Johansen from comment #12)
> (In reply to Marcin Haba from comment #10)
> > 1) add to Spec Requires and BuildRequires tags appropriate subversion
> > dependecies (>= 1.8.13-7)
> 
> I don't think that this is worth the trouble. Plus, it wouldn't be correct
> for all Fedora/EPEL releases.

Yes, it is worth the "trouble". If somebody will try to use your Spec and SRPM
to build hgsubversion with subversion < 1.8.13-7 then occur the same problem
with swig - Traceback and segfaults. I think that it is obligatory to add
dependecies that have chance to work with result RPM package.

> > 2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion
> > extension
> 
> I'll check with upstream on the recommended way to handle this. With most
> Mercurial extensions, they default to off and have to be enabled. I realize
> that this one is a bit different, so I just want to make sure that upstream
> is ok with the "enabled by default" approach.

OK. Thanks. I will be waiting on response in this subject.

> > I a have question about tests cases from hgsubversion:
> > 
> > 1) Why all tests executed by run.py finished successfully with installed
> > subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone
> > action call?
> 
> I'm not sure. Is this reproducible with the current version? If not, it's
> probably not worth spending any time on.

No. Current version is OK with subversion >= 1.8.13-7. I double checked.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]