https://bugzilla.redhat.com/show_bug.cgi?id=1128337 --- Comment #5 from Christopher Meng <i@xxxxxxxx> --- (In reply to Nikos Mavrogiannopoulos from comment #3) > In addition to the comment above, you use OPTCFLAGS='%{optflags}', but I > don't see OPTCFLAGS being read by the makefile. Why not use > CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; make? The same for > OPTLDFLAGS; doesn't seem to be used anywhere. Are you serious? :) BR: netsurf-buildsystem has defined everything, although that's sorta obscure, from build.log you can verify as well still: ====================== COMPILE ====================== ccache cc -MMD -MP -D_BSD_SOURCE -I/home/rpmaker/rpmbuild/BUILD/libnsgif-0.1.2/include/ -I/home/rpmaker/rpmbuild/BUILD/libnsgif-0.1.2/src -Wall -W -Wundef -Wpointer-arith -Wcast-align -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -pedantic -D_ALIGNED="__attribute__((aligned))" -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -std=c99 -fPIC -DPIC -o build-i686-redhat-linux-i686-redhat-linux-release-lib-shared/src_libnsgif.o -c src/libnsgif.c ====================== LINK ====================== ccache cc -o build-i686-redhat-linux-i686-redhat-linux-release-lib-shared/libnsgif.so.0.1.2 build-i686-redhat-linux-i686-redhat-linux-release-lib-shared/src_libnsgif.o -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -shared -Wl,-soname,libnsgif.so.0 Also, see how libhubbub, libnsbmp, libcss, libparserutils, libwapcaplet were packaged ;) example dependency issue solved: Spec URL: http://cicku.me/libnsgif.spec SRPM URL: http://cicku.me/libnsgif-0.1.2-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review