https://bugzilla.redhat.com/show_bug.cgi?id=1250025 --- Comment #1 from Honza Horak <hhorak@xxxxxxxxxx> --- Package Review ============== I've spotted those issues, that should be fixed: - soname is librocksdb.so.3.12, is this desired? I'd expect just librocksdb.so.3, but maybe upstream decided differently. It might be correct, but just wanted to be sure. - %defattr(-,root,root,-) is not needed - Package seems to contain bundled libraries: from build.log: CC third-party/gtest-1.7.0/fused-src/gtest/gtest-all.o and from spec (no gtest BuildRequirement) it seems gtest is bundled and used For third-party/fbson and third-party/flashcache I don't see them in build.log, but it would be better if we can remove all the third-party/ directory. - (not blocker) changing compiler flags should be done by setting variables like EXTRA_CFLAGS or EXTRA_CXXFLAGS, rather than redefining RPM_OPT_FLAGS: RPM_OPT_FLAGS="$RPM_OPT_FLAGS -std=c++11" Makefile doesn't have to be patched then. - I don't think we need to use explicit Requires, if those are libraries: Requires: jemalloc Requires: snappy Requires: bzip2 Requirements are specified automatically by RPM in those cases: libbz2.so.1()(64bit) libjemalloc.so.1()(64bit) libsnappy.so.1()(64bit) - (not blocker) no links nor comments in patches Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 137 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. - Package seems to contain bundled libraries: from build.log: CC third-party/gtest-1.7.0/fused-src/gtest/gtest-all.o and from spec (no gtest BuildRequirement) it seems gtest is bundled and used For third-party/fbson and third-party/flashcache I don't see them in build.log, but it would be better if we can remove all the third-party/ directory. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. - I don't think we need to use explicit Requires, if those are libraries: Requires: jemalloc Requires: snappy Requires: bzip2 Requirements are specified automatically by RPM in those cases: libbz2.so.1()(64bit) libjemalloc.so.1()(64bit) libsnappy.so.1()(64bit) [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rocksdb- devel - devel package should include %{?_isa} [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. - no links nor comments in patches [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: rocksdb-3.12-1.fc21.x86_64.rpm rocksdb-devel-3.12-1.fc21.x86_64.rpm rocksdb-3.12-1.fc21.src.rpm rocksdb.x86_64: W: spelling-error %description -l en_US tradeoffs -> trade offs, trade-offs, takeoffs rocksdb.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti rocksdb.x86_64: W: spelling-error %description -l en_US compactions -> compaction, comp actions, comp-actions rocksdb.x86_64: W: shared-lib-calls-exit /usr/lib64/librocksdb.so.3.12.0 exit@GLIBC_2.2.5 rocksdb.x86_64: W: no-documentation rocksdb-devel.x86_64: W: only-non-binary-in-usr-lib rocksdb-devel.x86_64: W: no-documentation rocksdb.src: W: spelling-error %description -l en_US tradeoffs -> trade offs, trade-offs, takeoffs rocksdb.src: W: spelling-error %description -l en_US multi -> mulch, mufti rocksdb.src: W: spelling-error %description -l en_US compactions -> compaction, comp actions, comp-actions 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: rocksdb-debuginfo-3.12-1.fc21.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- rocksdb (rpmlib, GLIBC filtered): /sbin/ldconfig bzip2 jemalloc ld-linux-x86-64.so.2()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgflags.so.2.1()(64bit) libjemalloc.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsnappy.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) snappy rocksdb-devel (rpmlib, GLIBC filtered): librocksdb.so.3.12()(64bit) rocksdb Provides -------- rocksdb: librocksdb.so.3.12()(64bit) rocksdb rocksdb(x86-64) rocksdb-devel: rocksdb-devel rocksdb-devel(x86-64) Source checksums ---------------- https://github.com/facebook/rocksdb/archive/v3.12.tar.gz#/rocksdb-3.12.tar.gz : CHECKSUM(SHA256) this package : eeb3cadb544e6eac8a3b6fde3c4b82e2de6a4c9bd721d426e2dde44285d48293 CHECKSUM(SHA256) upstream package : eeb3cadb544e6eac8a3b6fde3c4b82e2de6a4c9bd721d426e2dde44285d48293 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -o=--dnf -m fedora-21-x86_64 --rpm-spec -n rocksdb-3.12-1.fc21.src.rpm Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review