Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-Packet - A framework to easily send and receive frames from layer 2 to la yer 7 Alias: perl-Net-Packet https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239162 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-04 01:12 EST ------- You need to add build dependencies on perl(ExtUtils::MakeMaker), perl(Test), perl(Test::Pod::Coverage) and perl(Test::Pod). This will give you additional test coverage and will keep things building once the perl/perl-devel split is complete. * source files match upstream: a673b790fea0bb50d55063b6ca90233b7527f9263a7fa51bd4c43d16b32373c3 Net-Packet-3.25.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. X BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Net::Packet) = 3.25 perl(Net::Packet::ARP) perl(Net::Packet::CDP) perl(Net::Packet::CDP::Address) perl(Net::Packet::CDP::Type) perl(Net::Packet::CDP::TypeAddresses) perl(Net::Packet::CDP::TypeCapabilities) perl(Net::Packet::CDP::TypeDeviceId) perl(Net::Packet::CDP::TypePortId) perl(Net::Packet::CDP::TypeSoftwareVersion) perl(Net::Packet::Consts) perl(Net::Packet::Desc) perl(Net::Packet::DescL2) perl(Net::Packet::DescL3) perl(Net::Packet::DescL4) perl(Net::Packet::Dump) perl(Net::Packet::ETH) perl(Net::Packet::Env) perl(Net::Packet::Frame) perl(Net::Packet::ICMPv4) perl(Net::Packet::IGMPv4) perl(Net::Packet::IPv4) perl(Net::Packet::IPv6) perl(Net::Packet::LLC) perl(Net::Packet::Layer) perl(Net::Packet::Layer2) perl(Net::Packet::Layer3) perl(Net::Packet::Layer4) perl(Net::Packet::Layer7) perl(Net::Packet::NULL) perl(Net::Packet::OSPF) perl(Net::Packet::PPP) perl(Net::Packet::PPPLCP) perl(Net::Packet::PPPoE) perl(Net::Packet::RAW) perl(Net::Packet::SLL) perl(Net::Packet::STP) perl(Net::Packet::TCP) perl(Net::Packet::UDP) perl(Net::Packet::Utils) perl(Net::Packet::VLAN) perl-Net-Packet = 3.25-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Bit::Vector) perl(Carp) perl(Class::Gomor::Array) perl(Data::Dumper) perl(Exporter) perl(Net::IPv4Addr) perl(Net::IPv6Addr) perl(Net::Libdnet) perl(Net::Packet::ARP) perl(Net::Packet::CDP) perl(Net::Packet::CDP::Address) perl(Net::Packet::CDP::Type) perl(Net::Packet::CDP::TypeAddresses) perl(Net::Packet::CDP::TypeCapabilities) perl(Net::Packet::CDP::TypeDeviceId) perl(Net::Packet::CDP::TypePortId) perl(Net::Packet::CDP::TypeSoftwareVersion) perl(Net::Packet::Consts) perl(Net::Packet::Desc) perl(Net::Packet::DescL2) perl(Net::Packet::DescL3) perl(Net::Packet::DescL4) perl(Net::Packet::Dump) perl(Net::Packet::ETH) perl(Net::Packet::Env) perl(Net::Packet::Frame) perl(Net::Packet::ICMPv4) perl(Net::Packet::IGMPv4) perl(Net::Packet::IPv4) perl(Net::Packet::IPv6) perl(Net::Packet::LLC) perl(Net::Packet::Layer) perl(Net::Packet::Layer2) perl(Net::Packet::Layer3) perl(Net::Packet::Layer4) perl(Net::Packet::Layer7) perl(Net::Packet::NULL) perl(Net::Packet::OSPF) perl(Net::Packet::PPP) perl(Net::Packet::PPPLCP) perl(Net::Packet::PPPoE) perl(Net::Packet::RAW) perl(Net::Packet::SLL) perl(Net::Packet::STP) perl(Net::Packet::TCP) perl(Net::Packet::UDP) perl(Net::Packet::Utils) perl(Net::Packet::VLAN) perl(Net::Pcap) perl(Net::Write::Layer2) perl(Net::Write::Layer4) perl(Socket) perl(Socket6) perl(Storable) perl(Time::HiRes) perl(constant) perl(strict) perl(warnings) X %check is present. Many tests are necessarily skipped because they need the network. Some tests are skipped due to missing dependencies. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review