https://bugzilla.redhat.com/show_bug.cgi?id=1243530 --- Comment #30 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> --- Spec URL: https://jgu.fedorapeople.org/winswitch.spec SRPM URL: https://jgu.fedorapeople.org/winswitch-0.12.21-15.fc22.src.rpm * Thu Aug 13 2015 Jonathan Underwood <jonathan.underwood@xxxxxxxxx> - 0.12.21-15 - Replace /usr/bin/env python from files with %%{__python2} * Thu Aug 13 2015 Jonathan Underwood <jonathan.underwood@xxxxxxxxx> - 0.12.21-14 - Remove shebang from top of /etc/winswitch/firewall file and fix perms to not include executable bit * Thu Aug 13 2015 Jonathan Underwood <jonathan.underwood@xxxxxxxxx> - 0.12.21-13 - Add appdata file - Remove all bonjour related files (only used on OSX) - Remove bundled python pam module and use system wide version (In reply to Zbigniew Jędrzejewski-Szmek from comment #29) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > > Not a blocker for review, but it would be nice to provide an appdata file > > [https://fedoraproject.org/wiki/Packaging:AppData]. > It would be really nice to have an appdata file. > Done. > Unfortunately there's more bundling: > > witch/net/pybonjour.py -- this is bundled > http://code.google.com/p/pybonjour/. Fortunately the latest upstream version > is bundled. > I've simply removed this - this is only needed on OSX. > The code in winswitch/twisted also looks a bit suspicious. But those are > snippets of code, not a separate thing. They also appear to be > windows-specific. Please check if they can be removed in %prep. > They're still needed on Linux. > winswitch/util/pam.py appears to be bundled python-pam. Fedora version is > newer. > Remove bundled version and adjusted code to use system wide version. > Other files look good. > > Please own /usr/share/nautilus-python dir. > It was already owned. > winswitch.noarch: E: executable-marked-as-config-file /etc/winswitch/firewall > Please remove the executable bit and the #!/bin/sh header. > Fixed > Requires > -------- > winswitch (rpmlib, GLIBC filtered): > /bin/bash <---- this one comes from > /usr/libexec/winswitch/firewall, OK. > /bin/sh <---- this one comes from /etc/winswitch/firewall, so > should go away when /etc/winswitch/firewall header is removed. > /usr/bin/env <---- this one comes from /usr/libexec/winswitch/*. Most > likely those should be edited to use %{__python2}. Fixed. > /usr/bin/python2 <---- OK. > > More work for you, sorry :) No need to apologise! Thanks for catching all these things. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review