[Bug 1252530] Review Request: smaclient - Provides access to z/VM System Management functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1252530



--- Comment #1 from Dan Horák <dan@xxxxxxxx> ---
few notes
- you can remove "rm -rf $RPM_BUILD_ROOT" from %install, rpm does it
automagically
- add back %defattr() and remove the individual %attr()
- you are installing the smiucv C code instead of the built binary

full rpmlint output from the source and binary rpms:
smaclient.src: W: no-version-in-last-changelog
smaclient.src: W: strange-permission smaclient-1.1 775
smaclient-debuginfo.x86_64: W: no-version-in-last-changelog
smaclient-debuginfo.x86_64: E: empty-debuginfo-package
smaclient.x86_64: W: no-version-in-last-changelog
smaclient.x86_64: E: no-binary
smaclient.x86_64: W: no-documentation
smaclient.x86_64: E: script-without-shebang /usr/bin/smiucv
smaclient.x86_64: W: no-manual-page-for-binary smaclient
smaclient.x86_64: W: no-manual-page-for-binary smiucv
3 packages and 0 specfiles checked; 3 errors, 7 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]