https://bugzilla.redhat.com/show_bug.cgi?id=1246974 --- Comment #11 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to leinfeva from comment #10) > Now answer you question about the rm -rf %{buildroot}%{gem_instdir}/tmp in > %check section, well i see this line in other fedora spec file. so this is > was the only reason for add this line to the spec. also i've update the spec > file following your suggestions. thanks for this :) Ah, ok :) I might be needed somewhere probably, but this would be needed only on case by case basis. > now i will make review of other packages. Great! Actually is the test suite executed at all? It seems that the test suite is written using RSpec syntax, while you try to execute it as it was MiniTest ... Hint: Just to explain, so far I am providing the feedback just as I am reading through your .spec file. The definitive answer to my question would provid link to Koji scratch build, e.g. "fedpkg scratch-build --srpm" and this in turn helps to provide better feedback by your reviewer (or random person interested in your package). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review