https://bugzilla.redhat.com/show_bug.cgi?id=1245932 --- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- (In reply to William Moreno from comment #2) > Package Review > ============== > > Need Work: > ?: Sources contain only permissible code or content. > The shairplay-key file is redistributalbe? Which file exactly? > > Fail: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > Please a License Breakdown file as Source and include it with > %license, > can the attached file. The license file in %license describes exactly the license of each part of the source code. > ?: Package contains desktop file if it is a GUI application. > This app runs with a graphical interfase??? If yes > you must include a name.deskptop and a name.appdata.xml file Please consider the description and the content of the package: - it's a library - there's no executable provided by this library. > ?: Package contains systemd file(s) if in need. > This app runs as a system service? If yes you must include a systemd > unit file so user can start the service with > systemctl start shairplay See above (once again, it's nothing else than a library). > shairplay.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libshairplay.so.0.0.0 /lib64/libm.so.6 Not a blocker, fortunately. > AutoTools: Obsoleted m4s found > ------------------------------ > AC_PROG_LIBTOOL found in: shairplay- > 0f41ade2678f374aa8446d127d6aa9d5a3d428da/configure.ac:14 Not a blocker too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review