https://bugzilla.redhat.com/show_bug.cgi?id=1249078 --- Comment #5 from Pete Travis <me@xxxxxxxxxxxxxx> --- Okay, I've taken a closer look. A few housekeeping items: - s/novarc's/novarc files/ - or something. Apostrophes are for possessives and contractions. Pet peeve, not a review issue :) but seriously, please don't. - s/%{__python/%{__python2/g . Not a dealbreaker, but good practice, and won't break your spec if the macro's defaults change. Also, using %{python2_version} instead of ?.? will make a py3 subpackage easier down the road. - some missed opportunities for %{name} in %files/*egg-info. - This needs a populated %doc or -docs subpackage. Speaking of which, I see the examples use rackspace auth - I'll put together a review for it. - Use the %license macro for F21+.^FEPEL might need conditionals for this bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review