https://bugzilla.redhat.com/show_bug.cgi?id=1250833 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@xxxxxxxxx --- Comment #3 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- I'm not a sponsor, but I will give you some notes. -> Source0: https://github.com/mtytel/helm/archive/v0.4.1.zip Source0: https://github.com/mtytel/helm/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz Look at: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags You also can use %{url} instead of first part in Source0 tag -> Requires: mesa-libGL, alsa-lib, jack-audio-connection-kit, freetype, libXrandr, libXinerama, libXcursor, helm-common Please make it separate (I mean in some lines, not it one. I don't think that most of them is needed (I'm sure that RPM will pick up 90% of them automatically) -> Requires: helm-common you should specify version at least. Example: Requires: helm-common = %{version} -> For common subpkg please build noarch version. -> $RPM_BUILD_ROOT replace with %{buildroot} -> make %{?_smp_mflags} you could use %make_build -> "%_libdir/lv2/helm.lv2/helm.so" don't need to use quotes there -> Also i think you just want to have there just: %{_libdir}/lv2/helm.lv2/ don't need to specify files manually The same for common subpackage -> %doc COPYING should be %license COPYING -> "%{_bindir}/helm" again, no quotes and try to use %{name} where it's possible -> %setup -q You could use %autosetup -> License: GPL3 GPL3 is not valid license. You'd want GPLv3 or GPLv3+ (haven't checked sources) -> I've not checked desktop file, but looks like no icons in hicolor theme, only in /usr/share/helm. So if you want to use icons there -- use %{_datadir}/icons/hicolor/* as place for icons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review