https://bugzilla.redhat.com/show_bug.cgi?id=1249368 --- Comment #10 from Scott Talbert <swt@xxxxxxxxxx> --- (In reply to Jonathan Underwood from comment #9) > Hi Scott, > > OK, a few things: > > 1) Currently the examples directory is installed in the python site packages > directory. This stuff would probably be better installed as documentation, > unless there's a good reason why that would hinder use somehow. > > 2) There's some tests under pyqtgraph/tests which should be run during > %check if possible. > > 3) There's a doc directory with a Makefile for building documentation. I > think at the least html and pdf docs should be made (you'll need a BR for > sphinx) and packaged as documentation. > > 4) rpmlint is currently giving these errors dire to the examples having > shebangs at the top, but being installed under /usr/lib. Packaging the > examples as docs rather than installing them would silence these, of course. OK, I believe this is all done now. Examples are moved to docs. Tests are now being run. This added a bit of bloat to the build-deps as an X server is required, but I guess that's OK. Some of the tests had to be disabled, but they are disabled in upstream master also. It turns out that the API documentation was already pre-built by upstream, it just needed to be included. Rpmlint errors are gone. Spec: http://www.techie.net/~talbert/python-pyqtgraph.spec SRPM: http://www.techie.net/~talbert/python-pyqtgraph-0.9.10-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review