https://bugzilla.redhat.com/show_bug.cgi?id=1238301 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok b67d104316c9e426f4fb611f7463a523 qtcanvas3d-opensource-src-5.5.0.tar.xz licensing: ok macros: ok scriptlets: ok (MOSTLY) 1. SHOULD remove not-needed %post -p /sbin/ldconfig %postun -p /sbin/ldconfig this package has no shared libraries (only qml) 2. SHOULD look into use of qtdeclarative private interfaces (and tighten dependencies) .spec is simple and clean no blockers, APPROVED (can fix SHOULD items after import) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review