Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-mission-control - Central control for Telepathy connection manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241530 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|peter@xxxxxxxxxxxxxxxx |bdpepple@xxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2007-06-02 11:06 EST ------- MD5Sums: aa8a8264c596c666f886f85356b56e09 telepathy-mission-control-4.22.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Builds fine in mock for devel-i386. see attached build log. * rpmlint produces no errors. * package installs cleanly on F7. Bad: * Missing requires on libtelepathy-devel, dbus-devel, and dbus-glib-devel for the -devel subpackage. To help finding requires necessary for the -devel subpackage in the future try doing something like this: LANG=C grep 'include ' `rpm -ql telepathy-mission-control-devel` | grep -v Binary | sed -e 's|^.*:||' | sed -e 's|^[ \t][ \t]*||' | sort | uniq or this: rpm -ql telepathy-mission-control-devel | grep '/usr/lib/pkgconfig/.*.pc' | xargs cat | grep Requires +1 APPROVED, fix the requires on the -devel package before importing into CVS. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review