Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ipcalculator - A utility for computing broadcast, network, mask, and host ranges https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241654 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-06-02 07:07 EST ------- The sed substitution may also be along: sed -i 's:/usr/local/bin/ipcalc/:%{_bindir}/ipcalculator:' \ $RPM_BUILD_ROOT%{_datadir}/%{name}/ipcalculator.cgi Regarding the package name, this deviation is accepted in the guidelines since it adds a best judgement clause. And in that case indeed there could be confusion with the other ipcalc. You should own the %{_datadir}/%{name}/ directory. You should also patch the program to use ipcalculator instead of ipcalc in help message. Unless I am wrong it could also be achieved by sed -e 's/ipcalc /%{name} /' I know it is a small package, but you may want to split the cgi part and the main script anyway since they correspond with very different uses in my opinion. Also, especially in case you have a -cgi subpackage, you may consider shipping a config file for apache, as doc or in /etc/httpd/conf.d such that the cgi works more easily out of the box. Having a config file for httpd already installed has advantages (works out of the box) and inconvenients (may create security issues if it isn't required to change something manually by the local admin). All that is optional and left to your best judgement. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review