https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Ilya Gradina from comment #5) > add license file as SOURCE2, Thanks, although upstream issue or PR would be enough. BTW if you include some patch or LICENSE file in this case, it is good habit to provide some comment with reference, where you taken it. That way, next time you or anybody else touch this .spec file, will have a chance to check what is the progress of that issue. The patch could be already merged and the license shipped in latest release or it might be time to ping upstream again. > but I don't understand what did you mean by > that "to expand the test suite in %check section". You did "tar xf %{SOURCE1}" to expand the test suite in %prep section, but you don't need this code for anything else except %check section. Hence you could move it into %check section. That way you would be sure it will not propagate into the output RPM by accident. Nevertheless, that is my preference and somebody else could disagree. So this is just to explain. Your current approach is just fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review