https://bugzilla.redhat.com/show_bug.cgi?id=1245255 --- Comment #6 from Jens Lody <fedora@xxxxxxxxxxx> --- Informal review: I do not use python myself, so I'm not familiar to it. Did you read: https://fedoraproject.org/wiki/Packaging:Python ? If I understand correctly you should not use the generic ${python} (etc.) macros, but the specific ${python2} (etc.) version, to be sure the package works, if the default switches from python2 to 3. Besides the python-specific stuff: Don't use rm -rf %{buildroot} at the beginning of %install Install the man-page with "-m 644" parameter to avoid setting the executable-bit Remove the %clean-section defattr in %files only needed for rpm < 4.4 (even RedHat/CentOS 5 has 4.4.x) Your license-file is unclear about the correct license, it mentions GPLv2+ and GPL3+, the spec-file says You use GPLv2+. In the sources you only write about GPL without any version. Please check: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines and https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing Please test your package also with fedora-review -b 1245255 -m fedora-rawhide-x86_64 (see the man-page of fedora-review for the -m parameters if you want to test different mock-configurations). This is just an informal review, I'm not a fedora-packager, "just" a contributor looking for a review (and a sponsor) myself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review