https://bugzilla.redhat.com/show_bug.cgi?id=1246792 --- Comment #5 from Dan Williams <dan.j.williams@xxxxxxxxx> --- (In reply to Igor Gnatenko from comment #4) > I don't think that you need separate libs subpackage. > > -> %{_includedir}/* > Will own wrong directories (systemd, for example). Changed to: %{_includedir}/ndctl/* > -> rm -rf $RPM_BUILD_ROOT > Is not needed Deleted. > -> %doc > No docs Do I need to delete this until docs are ready, or can the spec have this as a placeholder until then? > -> * Wed Aug 27 2014 Dan Williams > Changelog isn't in needed format Deleted. > -> ./autogen.sh > Not sure, but probably you want to use "NOCONFIGURE=1 ./autogen.sh" to > avoid configuring twice Verified that configure is called only once. > -> %global __requires_exclude pkg-config > nope, you don't co-own directory. You don't need to do this. Deleted. ...will attach updated .spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review