https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Igor Gnatenko from comment #3) > you should change this bug title. This would be nice but not super-important. And the upstream summary/description is pretty brief I must say. * Test suite expansion - I would suggest to expand the test suite in %check section. This will avoid accidental inclusion of the test suite in resulting RPM. - If you prefer to keep it in %prep section, then you should probably use %setup macro with -a 1 or -b 1 parameters [1]. - You don't really need to delete the test suite after its execution, if you are using mock (not sure about local build thoug). * License text - The package does not contain any license information. You should contact upstream and encourage them to correct this mistake [2, 3]. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10587608 Otherwise, the package looks good. Could you please do some informal review so I can sponsor you? [1] http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html [2] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review