[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1232816



--- Comment #3 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
Hi Zuzana,


It seems that this module needs to be built, see package.json:
  "scripts": {
    "build": "node build/parser.js > source/parser.generated.js",


The generated file is needed for proper functioning, see spdx.js:
source/spdx.js:var parser = require('./parser.generated.js').parser;


Building depends on npm(jison) which is not in Fedora yet.



Small other comment:
If you are targetting el6 than you have to change the ExclusiveArch:

%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif

If you are not buildinf for el6 then you can remove the 
%{?nodejs_find_provides_and_requires}
macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]