[Bug 1244353] Review Request: ossim - Open Source Software Image Map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1244353



--- Comment #7 from Marcin Haba <marcin.haba@xxxxxxxxx> ---
Hello Rashad,

Thanks for the update in this task.

About errors:

1) ossim-data.x86_64: W: non-conffile-in-etc /etc/profile.d/ossim.sh

It looks that you can keep it as is now, because it is profile.d  shell type
file, not config file. For be 100% sure, I will ask somebody from Fedora
packages maintainers, and then let you know. If is need then I prepare patch
for rpmlint and send the patch to rpmlint author.

2) ossim-devel.x86_64: E: non-devel-file-in-devel-package
/usr/lib64/libossim.so.1.8.18

Because this dynamically linked library is used by users programs, for example:

$ ldd /usr/bin/ossim-cmm 
    linux-vdso.so.1 (0x00007ffcbdb7a000)
    libossim.so.1 => /lib64/libossim.so.1 (0x00007f2183d00000)        <====
here
    libOpenThreads.so.20 => /lib64/libOpenThreads.so.20 (0x00007f2183af8000)
    libgeos-3.4.2.so => /lib64/libgeos-3.4.2.so (0x00007f2183750000)
    libgeos_c.so.1 => /lib64/libgeos_c.so.1 (0x00007f2183528000)
    libgeotiff.so.2 => /lib64/libgeotiff.so.2 (0x00007f21832f0000)
    libjpeg.so.62 => /lib64/libjpeg.so.62 (0x00007f2183090000)
    libtiff.so.5 => /lib64/libtiff.so.5 (0x00007f2182e18000)
    libdl.so.2 => /lib64/libdl.so.2 (0x00007f2182c10000)
    libz.so.1 => /lib64/libz.so.1 (0x00007f21829f8000)
    libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f2182670000)
    libm.so.6 => /lib64/libm.so.6 (0x00007f2182368000)
    libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f2182150000)
    libc.so.6 => /lib64/libc.so.6 (0x00007f2181d90000)
    libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f2181b70000)
    libproj.so.0 => /lib64/libproj.so.0 (0x00007f2181920000)
    libjbig.so.2.1 => /lib64/libjbig.so.2.1 (0x00007f2181710000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f2184f00000)

I guess that it is not devel type file. The Packaging Guidelines says here:

https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#DevelPackages

that there is possible to include in -devel packages only reasonable selected
shared libraries. As you will see in above guidelines, one from general advises
is to determine for which purposes is used library: for a developer or for
users. If it is used for development then a file needs to be moved to -devel
package, if for user applications, then a file needs to be moved to base
package.

Also the library file is already included in two packages:

- ossim-1.8.18-2.fc21.x86_64.rpm
- ossim-devel-1.8.18-2.fc21.x86_64.rpm

so it causes second problem - doubled the same library in two different RPM
packages.

If you decide that the library is used for users application, not for
development, I propose to not include this library in devel package, and then
both above issues (rpmlint error and doubled file) become fixed.

3) ossim-devel.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libossim.so.1.8.18

I also have no idea why the error occurs, because it is compatible with
Guidelines:

https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries

However the error appears only on -devel package, so I guess that it will be
fixed when you do not include library in -devel package.


If you want add to this task your SRPM file via FedoraPeople service then you
can follow on this link:

https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org#Accessing_Your_fedorapeople.org_Space

Here is described what you need to open FedoraPeople account.

I hope that it helps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]