https://bugzilla.redhat.com/show_bug.cgi?id=1246891 --- Comment #2 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> --- Thanks for the review! (In reply to William Moreno from comment #1) > Package Review > ============== > > NEED WORK: > > 1- Use compiler flags by default: > > !: %build honors applicable compiler flags or justifies otherwise. > %cmake sets the compiler flags. See the build.log to confirm that the package is built with all required flags. checksec gives the following output: Full RELRO Canary found NX enabled PIE enabled No RPATH No RUNPATH > > 2- The missing manpage is a easy fix the package manedit (UNIX Manual Page > Editor) to create a manpage and add it ass Source1, if you create a manpage > please propose it to upstream. Thanks for the hint. I'll have a look. > > 3- Build failed in ppc64le > !: Package should compile and build into binary rpms on all supported > architectures. > > See: > http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/ > monitor/ Looking at the output, this is clearly a COPR error. From root.log: DEBUG util.py:377: Failed to synchronize cache for repo 'coprbecloudfedoraprojectorg_results_williamjmorenor_fedorareviewtest_fedorarawhideppc64le_devel_' from 'https://copr-be.cloud.fedoraproject.org/results/williamjmorenor/fedora-review-test/fedora-rawhide-ppc64le/devel/': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried, disabling. The build never started, build.log is empty. Only the epel6 build failure is actually due to this package, because the Spec file uses %license, which is not defined in epel6. I will not submit the package to epel6. I've tried a COPR build too, with similar results: https://copr.fedoraproject.org/coprs/thofmann/review-test/build/106723/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review