[Bug 1225231] Review Request: light-locker-settings - Just a simple settings dialog for light-locker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1225231



--- Comment #12 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
Some notes about licensing. Python files marked as GPLv3 only (without possible
to next version). COPYING file yes, about GPLv3+. Please notice upstream about
this crap.

-> sed '/INSTALL/d' Makefile.in.in
   You want to also add "-i" option
-> light-locker-settings.x86_64: E: no-binary
   I'm not happy with custom sh script in /usr/bin which runs
   "python /usr/share". I would happy to see if it will python script which
does
   "import light-locker-settings; light-locker-settings.run()" or something
like
   this. I hope you will poke upstream.
-> light-locker-settings.x86_64: W: dangling-symlink
/usr/share/light-locker-settings/locale /usr/share/locale
   It should be fixed. gettext in light-locker-settings should use system path
   instead of making such links.
-> light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/INSTALL
-> light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/NEWS
-> light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/AUTHORS
-> light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/README
-> light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/COPYING
    Do "chmod -x" for those files
-> light-locker-settings.x86_64: E: script-without-shebang
/usr/share/light-locker-settings/light-locker-settings/light-locker-settings.glade
    Do "chmod -x" for it
-> light-locker-settings.x86_64: W: no-manual-page-for-binary
light-locker-settings
    Ignore
-> light-locker-settings.x86_64: W: install-file-in-docs
/usr/share/doc/light-locker-settings/INSTALL
    Not needed


All stuff about docks SHOULD be installed by `%doc`, not by program. Would be
great to make a patch and sent upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]