https://bugzilla.redhat.com/show_bug.cgi?id=1247795 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > Thanks for taking this. Thanks for resurrecting execstack. Several of my packages depend on it at build time. > I removed both ExclusiveArch and Group. EA was taken from the prelink > package, but it looks like it might not be needed at all. The only > architecture that is still present in Fedora, and was not on this list, is > MIPS. > > spec and srpm updated in place. Great, the package is APPROVED, though I do have a couple more nitpicks you can fix when importing: 1. Please drop Requires: glibc >= 2.2.4-18 (EL-5 has glibc-2.5) and reformat the rest of the (Build)Requires one per-line and sort alphabetically. 2. Please add a comment explaining this in %build: sed -i -e '/^prelink_LDADD/s/$/ -lpthread/' src/Makefile.{am,in} 3. Please add -p to install commands: install -D src/execstack %{buildroot}%{_bindir}/execstack install -Dm0644 doc/execstack.8 %{buildroot}%{_mandir}/man8/execstack.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review