https://bugzilla.redhat.com/show_bug.cgi?id=1193990 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |valtri@xxxxxxxxxx Flags| |fedora-review? --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- Taking the review. Issues found: 1) I had problem with build and autotools on Fedora 24/rawhide (it complains about libtool version changes) It was working when used the upstream way instead of autoreconf: # https://sourceforge.net/p/opencity/code/HEAD/tree/trunk/opencity/autogen.sh aclocal libtoolize -c autoconf autoheader automake -a -c This way, Makefile.in will be regenerated from Makefile.am, so the patch 'opencity.remove_install_files.patch' would need to be updated to patch the Makefile.am instead (but the patch maybe won't be needed? as suggested in 10)?). 2) fedora-review: Obsoleted m4s macros found AC_PROG_LIBTOOL found in: opencity-0.0.6.5stable/configure.ac:30 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools 3) build fails on appdata check It should be used "appstream-util validate-relax --nonet ...". Also there is probably misplaced </p> tag (funny is the validator doesn't complain about it). See: http://fedoraproject.org/wiki/Packaging:AppData 4) rpmlint: opencity-debuginfo.x86_64: E: debuginfo-without-sources There is a problem with build flags - they are overwritten in %build. It can be fixed by adding also %{optflags} to CXXFLAGS. 5) configure: WARNING: unrecognized options: --disable-binreloc, --disable-binreloc-threads These parameters are not needed. (Not important, just small simplification.) 6) -data subpackage: better to have it as noarch package: "BuildArch: noarch" 7) tinyxml and tinyxpath runtime requires not needed: it is better to handle library runtime dependencies automatically 8) rpmlint: opencity-data.x86_64: W: summary-ended-with-dot C Data files for opencity. 9) rpmlint: opencity.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 54) Not important. It is possible to replace tabs in the sed commands by '\s' and '\t'. 10) fedora-review complains about license files in /usr/share/doc (they are already in /usr/share/license) It could be used something like that?: % install # documentation handled by %%doc rm -fv %{buildroot}%{_defaultdocdir}/%{name} %files %doc AUTHORS README doc/FAQ* doc/README* (another way could be removing only the copyright files in the %install, but it is better not to combine absolute and relative paths in %doc/%license macros) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review