[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1242896

Julien Enselme <jujens@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jujens@xxxxxxxxx) |



--- Comment #3 from Julien Enselme <jujens@xxxxxxxxx> ---
(In reply to Dmitry Tantsur from comment #2)

> - You've tried to install the package on F21. I'm pretty sure it does not
> have all the dependencies. The following succeeds:
> sudo mock -r fedora-rawhide-x86_64 -i
> https://kojipkgs.fedoraproject.org//work/tasks/1987/10351987/python-ironic-
> inspector-client-1.0.1-1.fc23.noarch.rpm

Just tested with:
fedora-review -b 1242896 -m fedora-rawhide-x86_64

it works fine.
> 
> - By python 3 support upstream means unit tests pass on Python 3 mostly. As
> python-openstackclient is only involved in a shell script, it's not a big
> deal for tests. But we probably can't declare Python 3 compatibility until
> it's fixed.

OK, this was just to know.
> 
> - `python -m unittest discover ironic_inspector_client.test` works, though
> requires python-mock (not sure how to handle it, as it's not a runtime
> dependency for the project itself).

You should add the dependency as BuildRequires. Once this is done, I will
approve the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]