[Bug 1206732] Review Request: python-gccjit - Python bindings for libgccjit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1206732

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from 
> distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}

> %if 0%{?fedora} > 12

You can drop that, unless you want to package for old EPELs too.

Must Provide: python2-gccjit = %{version}-%{release}

Do you need the whole dance with %{py3dir}? Unless you use 2to3 or modify the
sources during build in another way, it should be fine to build both versions
from the same source directory.

> rm -rf $RPM_BUILD_ROOT
Allowed, but also obsolete.

Also consider adding %global _docdir_fmt %{name}. No need for duplicate dirs
with the same contents.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]