https://bugzilla.redhat.com/show_bug.cgi?id=1244514 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Add Provides python2-snappy = %{version}-%{release}. Putting _snappy in the global namespace is an abomination. Somebody should hit upstream with a cluebat. You changed %{py3dir} to python2 and python3 dirs. This is better, but best would be getting of the dirs completely. This will follow the new draft guidelines that are being worked on, so you'll be ready for the future :) So I'd strongly suggest removing all the copying and push/popd-ing. Also consider adding %global _docdir_fmt %{name}. No need for duplicate dirs with the same contents. Looks good. The only required change would be the added provides, the other two are suggestions. Either way, please post a new version so that I can ack it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review