https://bugzilla.redhat.com/show_bug.cgi?id=1247328 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- if [ $1 ]; then command -v xxd >/dev/null 2>&1 || { echo >&2 "sshrc requires xxd to be installed locally, but it's not. Aborting."; exit 1; } sshrc $@ This is an accident waiting to happen. Proper quoting is required around $@. [ $1 ] will go wrong if options are given on the command line. xxd is requires but it is not Required by anything. rm -rf %{buildroot} is not necessary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review