[Bug 1235831] Review Request: vim-vcscommand - version control system commands from within vim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1235831



--- Comment #6 from Nikola Forró <nforro@xxxxxxxxxx> ---
A few notes on the spec:

License tag is wrong, it must contain license short name. The license of the
project is actually MIT. See:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names
https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_with_sublicense

No URL for Source0, you should mention it in comment or you can use something
like this:
http://www.vim.org/scripts/download_script.php?src_id=19809#/%{name}-%{version}.zip
See: https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

Correct group name is Applications/Editors. See:
https://fedoraproject.org/wiki/RPMGroups

Changelog entry should include release number. See:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs

Are you interested in full review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]