[Bug 1248110] Review Request: python-process-tests - Tools for testing processes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1248110

José Matos <jamatos@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jamatos@xxxxxxxx



--- Comment #1 from José Matos <jamatos@xxxxxxxx> ---
Hi Orion,
  this is nice package. :-)

I have just a small remark, you are owning %{python3_sitelib}/__pycache__ and
according to the guideline you should not. That is you should own the files but
not the directory.
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

The suggestion is then to replace

%{python3_sitelib}/*

by

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/%{srcname}*egg-info
%{python3_sitelib}/*.py

Or equivalent, you choose. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]