https://bugzilla.redhat.com/show_bug.cgi?id=1247243 Marcin Juszkiewicz <mjuszkie@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjuszkie@xxxxxxxxxx --- Comment #3 from Marcin Juszkiewicz <mjuszkie@xxxxxxxxxx> --- Note that I never did Fedora package review before. My notes: Have you used rpmlint? Provide links to scratch builds on primary. use -p1 patches please use %configure macro instead of ./configure define module_dirs once use '%license lgpl.txt' instead of %doc add %changelog entry with proper description -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review