https://bugzilla.redhat.com/show_bug.cgi?id=1198473 Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |e@xxxxxxxxxxxxxxxx Docs Contact| |e@xxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> --- The Python Packaging Guidelines have changed since you submitted your package, so now it does not comply them. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - %{py3dir} must not be used. Instead, use in %prep: %if 0%{?with_python3} cp -a python2 python3 find python3 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 find python2 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|' Similarly use python2 and python3 directory names as given for other parts of spec file like %build, %install, %check from https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file - A python2- subpackage is needed. Use: %description Applications with more than a handful of user-settable options are best configured through a combination of command line args, config files, hard ... %package -n python2-%{srcname} Summary: %{summary} %{python_provides:%python_provides python2-%{srcname}} %description -n python2-%{srcname} Applications with more than a handful of user-settable options are best ... - For F23+ use: %{__python2} setup.py build -> %py2_build %{__python3} setup.py build -> %py3_build %{__python2} setup.py install --skip-build --root %{buildroot} -> %py2_install %{__python3} setup.py install --skip-build --root %{buildroot} -> %py3_install - The timestamps of the sources are not preserved. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-configargparse-0.9.3-1.fc24.noarch.rpm python3-configargparse-0.9.3-1.fc24.noarch.rpm python-configargparse-0.9.3-1.fc21.src.rpm python-configargparse.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-configargparse.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure python-configargparse.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy python-configargparse.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python-configargparse.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python-configargparse.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python3-configargparse.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python3-configargparse.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure python3-configargparse.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy python3-configargparse.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python3-configargparse.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python3-configargparse.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python-configargparse.src: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-configargparse.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure python-configargparse.src: W: spelling-error Summary(en_US) env -> enc, en, envy python-configargparse.src: W: spelling-error %description -l en_US args -> rags, gars, ares python-configargparse.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python-configargparse.src: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse 3 packages and 0 specfiles checked; 0 errors, 18 warnings. Rpmlint (installed packages) ---------------------------- python-configargparse.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python-configargparse.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure python-configargparse.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy python-configargparse.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python-configargparse.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python-configargparse.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse python3-configargparse.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse python3-configargparse.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure python3-configargparse.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy python3-configargparse.noarch: W: spelling-error %description -l en_US args -> rags, gars, ares python3-configargparse.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure python3-configargparse.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse 2 packages and 0 specfiles checked; 0 errors, 12 warnings. Requires -------- python-configargparse (rpmlib, GLIBC filtered): python(abi) python3-configargparse (rpmlib, GLIBC filtered): python(abi) python3 Provides -------- python-configargparse: python-configargparse python3-configargparse: python3-configargparse Source checksums ---------------- https://pypi.python.org/packages/source/C/ConfigArgParse/ConfigArgParse-0.9.3.tar.gz : CHECKSUM(SHA256) this package : 141c57112e1f8eb7e594a9820e95af897a7fa2d186cef5cff7e08cb3f7252829 CHECKSUM(SHA256) upstream package : 141c57112e1f8eb7e594a9820e95af897a7fa2d186cef5cff7e08cb3f7252829 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review