https://bugzilla.redhat.com/show_bug.cgi?id=1247747 Christian Dersch <lupinix@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Christian Dersch <lupinix@xxxxxxxxxxx> --- Looks nice, approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ==> Not an issue, not an application desktop file ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/xfce4/backdrops [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnome-background- properties, /usr/share/mate-background-properties, /usr/share/xfce4/backdrops ==> IMHO ok [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ==> We (Fedora) are the upstream... [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f23 -backgrounds-base , f23-backgrounds-kde , f23-backgrounds-gnome , f23 -backgrounds-mate , f23-backgrounds-xfce [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: f23-backgrounds-23.0.1-1.fc24.noarch.rpm f23-backgrounds-base-23.0.1-1.fc24.noarch.rpm f23-backgrounds-kde-23.0.1-1.fc24.noarch.rpm f23-backgrounds-gnome-23.0.1-1.fc24.noarch.rpm f23-backgrounds-mate-23.0.1-1.fc24.noarch.rpm f23-backgrounds-xfce-23.0.1-1.fc24.noarch.rpm f23-backgrounds-23.0.1-1.fc24.src.rpm f23-backgrounds.noarch: W: no-documentation f23-backgrounds-base.noarch: W: no-documentation f23-backgrounds-kde.noarch: W: no-documentation f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/800x480.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/640x480.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1200.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x960.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x800.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1200x900.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1600x1200.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1440x900.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1080.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1152x720.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x768.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/2048x1536.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x720.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1024x600.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/800x600.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1440x1080.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1680x1050.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1366x768.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1600x1280.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1024x768.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1440.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x1024.png ../../../../backgrounds/f23/default/normalish/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1152x864.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-gnome.noarch: W: no-documentation f23-backgrounds-mate.noarch: W: no-documentation f23-backgrounds-xfce.noarch: W: no-documentation f23-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f23.png ../../backgrounds/f23/default/wide/f23.png 7 packages and 0 specfiles checked; 0 errors, 30 warnings. Rpmlint (installed packages) ---------------------------- f23-backgrounds.noarch: W: no-documentation f23-backgrounds-kde.noarch: W: no-documentation f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1152x864.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x1024.png ../../../../backgrounds/f23/default/normalish/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x800.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1366x768.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1024x600.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1152x720.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x960.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1680x1050.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/640x480.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/800x600.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x768.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1600x1200.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/800x480.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1200x900.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/2048x1536.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1600x1280.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1440x900.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1440x1080.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1024x768.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1200.png ../../../../backgrounds/f23/default/wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1080.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1920x1440.png ../../../../backgrounds/f23/default/standard/f23.png f23-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F23/contents/images/1280x720.png ../../../../backgrounds/f23/default/tv-wide/f23.png f23-backgrounds-xfce.noarch: W: no-documentation f23-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f23.png ../../backgrounds/f23/default/wide/f23.png f23-backgrounds-base.noarch: W: no-documentation f23-backgrounds-gnome.noarch: W: no-documentation f23-backgrounds-mate.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 30 warnings. Requires -------- f23-backgrounds (rpmlib, GLIBC filtered): f23-backgrounds-gnome f23-backgrounds-kde f23-backgrounds-mate f23-backgrounds-xfce f23-backgrounds-kde (rpmlib, GLIBC filtered): f23-backgrounds-base kde-filesystem f23-backgrounds-xfce (rpmlib, GLIBC filtered): f23-backgrounds-base xfdesktop f23-backgrounds-base (rpmlib, GLIBC filtered): f23-backgrounds-gnome (rpmlib, GLIBC filtered): f23-backgrounds-base f23-backgrounds-mate (rpmlib, GLIBC filtered): f23-backgrounds-base Provides -------- f23-backgrounds: f23-backgrounds f23-backgrounds-kde: f23-backgrounds-kde f23-backgrounds-xfce: f23-backgrounds-xfce f23-backgrounds-base: f23-backgrounds-base f23-backgrounds-gnome: f23-backgrounds-gnome f23-backgrounds-mate: f23-backgrounds-mate Source checksums ---------------- https://fedorahosted.org/released/design-team/f23-backgrounds-23.0.1.tar.xz : CHECKSUM(SHA256) this package : 3514bb8a8ec2a4f2132e022013dc567f3868f5ca0c59a466d7bd025bf941d891 CHECKSUM(SHA256) upstream package : 3514bb8a8ec2a4f2132e022013dc567f3868f5ca0c59a466d7bd025bf941d891 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -b 1247747 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review