https://bugzilla.redhat.com/show_bug.cgi?id=1242724 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- Okay, that's better. A few more notes, however: * Sort your dependencies; they will be easier to read and you'll be less likely to miss something or list it twice. (`base' and `Carp', I'm looking at you!) * You still needlessly remove empty directories in %install, now on line 54. * You added some trailing whitespace, lines 36 and 69. That's just bad taste ;) * It looks like you forgot to bump the release number; now you have two changelog entries for one VR. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review