https://bugzilla.redhat.com/show_bug.cgi?id=1246120 --- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- Thanks for the review. Please see my comments inline: (In reply to Michal Cyprian from comment #2) > * There is non executable script > /usr/share/atomic-reactor/images/privileged-builder/docker.sh with > permissions 644. As a comment on line 239 notes, this file is not executable since it's not meant for direct use on user's system, but should only be used in a container (therefore the 644 privileges defend user from making unwanted harm). So hopefully, this is ok. > * The lastest revision of Packaging Guidelines:Python don't recommend to use > macro %{py3dir}. Fixed (I just don't use separate dirs for py3 build any more, which should be correct and still work). > * License of the package and license field in spec are alright. > * Package was compiled and build successfully. > * import of atomic_reactor module is working properly in both python2 and > python3 subpackages. > * It is still not possible to run it as you have already noticed. Since fixing bug 1245523 makes python-docker-py work again (until it's fixed properly as requested in bug 1245521), it should work now. Spec URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor.spec SRPM URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor-1.4.0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review