[Bug 1243061] Review Request: dex-autostart - Generate and execute DesktopEntry files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1243061



--- Comment #4 from Marcin Haba <marcin.haba@xxxxxxxxx> ---
Hello,

@Till:

Thanks for add the substring change to Spec file.

The package builds well on my side and manual looks OK either.

Here are two minor notes:

1) I checked that dex-autostart works with python3 and does not work with
python2. From this reason I propose to add a "Requires" tag python >= 3.4 or
something similar with relation to Python3. This change will give clear info
(also for packagers from other distributions) that dex-autostart works with
Python3 and higher.

2) Result RPM contains:

/usr/share/doc/dex-autostart/README.rst

in which content are texts and examples about 'dex' instead of 'dex-autostart'.
I propose to use the same way as you used in case manual, or just exclude this
file and do not add the README file to RPM due to containing almost the same
information as manual contains.

After applying above changes, I prepare informal review form and past the
results here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]