https://bugzilla.redhat.com/show_bug.cgi?id=1245640 --- Comment #1 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> --- Minor comments/questions after a first glance: - Why do you create backups during patching? - You use "buildconf x86_64" on ALL arch'es, are you sure this is intended? It certainly looks odd. - You can use a URL pointing to github as Source0 URL instead of using a local file, for details see [1] (although this probably won't work, see next comment). - It seems like you need to have the full git repository in order to specify the GIT_VERSION correctly. Couldn't you instead define the version when calling make (e.g. by defining additional CPPFLAGS)? I understand this would require some patching, but it seems like the cleaner solution. - Are the patches generic or are these Fedora-specific patches? If they are generic, are they included upstream? Did you send them upstream? [1] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review