[Bug 1245845] Review Request: python-scandir - faster version of os.walk included in PY3.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1245845



--- Comment #4 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
Taking a final look now.

ps it's preferable to use unified diff, because that shows the context in which
the change is made

e.g. diff -u python-scandir{-orig,}.spec
--- python-scandir-orig.spec    2015-07-24 23:51:39.183792897 +0700
+++ python-scandir.spec    2015-07-26 10:11:31.913915790 +0700
@@ -13,7 +13,6 @@
 License:        BSD

 BuildRequires:  python2-devel
-BuildRequires:  gcc

 %if 0%{?with_python3}
 BuildRequires:  python3-devel
@@ -30,7 +29,6 @@
 %if 0%{?with_python3}
 %package -n python3-%{pkgname}
 Summary:        A better directory iterator and faster os.walk() for Python
-Requires:       python(abi) < 3.5

 %description -n python3-%{pkgname}
 scandir() is a directory iteration function like os.listdir(), except that
@@ -49,10 +47,10 @@
 %endif

 %build
-%{__python} setup.py build
+CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
 %if 0%{?with_python3}
 pushd %{py3dir}
-%{__python3} setup.py build
+CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build
 popd
 %endif

@@ -88,6 +86,7 @@
 %{!?_licensedir:%global license %%doc}
 %license LICENSE*
 %doc README* test benchmark.py
+%exclude %dir %{python3_sitearch}/__pycache__
 %{python3_sitearch}/*
 %endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]