https://bugzilla.redhat.com/show_bug.cgi?id=1244353 --- Comment #5 from Marcin Haba <marcin.haba@xxxxxxxxx> --- Hello, Thanks for provided Spec and SRPM URLs. Minor note to SRPM URL. It indicates to service which needs to type captcha for download SRPM. For future SRPM URLs nicer could be provide direct link to SRPM. If you do not have any place to put SRPM, you can use https://fedorapeople.org/ service for that. OK. Comming back to review, I successfully built your packages. Rpmlint tool is showing a couple of errors and warnings on your packages. Here are errors: ossim-devel.x86_64: E: incorrect-fsf-address /usr/include/ossim/vpfutil/values.h ossim-devel.x86_64: E: non-devel-file-in-devel-package /usr/lib64/libossim.so.1.8.18 ossim-devel.x86_64: E: library-without-ldconfig-postin /usr/lib64/libossim.so.1.8.18 ossim-devel.x86_64: E: library-without-ldconfig-postun /usr/lib64/libossim.so.1.8.18 ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimAdjSolutionAttributes.cpp ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimGeodeticEvaluator.h ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimAdjSolutionAttributes.h ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimAdjSolutionAttributes.cpp ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimGeodeticEvaluator.h ossim-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimAdjSolutionAttributes.h ossim-devel.x86_64: E: incorrect-fsf-address /usr/include/ossim/vpfutil/values.h ossim-devel.x86_64: E: library-without-ldconfig-postin /usr/lib64/libossim.so.1.8.18 ossim-devel.x86_64: E: library-without-ldconfig-postun /usr/lib64/libossim.so.1.8.18 Here are warnings: ossim.x86_64: W: shared-lib-calls-exit /usr/lib64/libossim.so.1.8.18 exit@GLIBC_2.2.5 ossim.x86_64: W: no-documentation ossim-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libossim.so.1.8.18 exit@GLIBC_2.2.5 ossim-devel.x86_64: W: no-documentation ossim-data.x86_64: W: no-documentation ossim-data.x86_64: W: non-conffile-in-etc /etc/profile.d/ossim.sh ossim-data.x86_64: W: non-conffile-in-etc /etc/profile.d/ossim.csh ossim.src:66: W: macro-in-comment %setup ossim.src:141: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 141) ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/support_data/ossimNitfDataExtensionSegmentV2_1.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimAdjSolutionAttributes.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimBinaryDataProperty.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/support_data/ossimNitfImageDataMaskV2_1.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/support_data/ossimNitfDataExtensionSegmentV2_1.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimGeodeticEvaluator.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimAdjSolutionAttributes.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/support_data/ossimNitfImageDataMaskV2_1.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimBinaryDataProperty.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/support_data/ossimNitfDataExtensionSegmentV2_1.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimAdjSolutionAttributes.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimBinaryDataProperty.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/support_data/ossimNitfImageDataMaskV2_1.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/support_data/ossimNitfDataExtensionSegmentV2_1.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimGeodeticEvaluator.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/include/ossim/base/ossimAdjSolutionAttributes.h ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/support_data/ossimNitfImageDataMaskV2_1.cpp ossim-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/ossim-1.8.18/ossim/src/ossim/base/ossimBinaryDataProperty.cpp ossim.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libossim.so.1.8.18 /lib64/libgeos_c.so.1 ossim.x86_64: W: shared-lib-calls-exit /usr/lib64/libossim.so.1.8.18 exit@GLIBC_2.2.5 ossim.x86_64: W: no-documentation ossim-devel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libossim.so.1.8.18 /lib64/libgeos_c.so.1 ossim-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libossim.so.1.8.18 exit@GLIBC_2.2.5 ossim-devel.x86_64: W: no-documentation ossim-data.x86_64: W: no-documentation ossim-data.x86_64: W: non-conffile-in-etc /etc/profile.d/ossim.sh ossim-data.x86_64: W: non-conffile-in-etc /etc/profile.d/ossim.csh For knowing what does every error mean you can use rpmlint command with -I switcher, for example: $ rpmlint -I library-without-ldconfig-postin library-without-ldconfig-postin: This package contains a library and provides no %post scriptlet containing a call to ldconfig. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review