https://bugzilla.redhat.com/show_bug.cgi?id=1230963 --- Comment #25 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> --- (In reply to William Moreno from comment #23) > (In reply to Jonathan Underwood from comment #22) > > The spec file changelog has been badly line wrapped such that the > > version-release tag appears as the first entry - that needs fixing. You > > generally seem to have an issue with line wrapping (as seen in other > > reviews) - I suggest you turn line wrapping off in whatever editor you use > > as it is wasting you a lot of time. > > No, the changelog it is in prescribed format, see the 3rd options: > https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > > Ah, yes, I hadn't realized that format was acceptable, I stand corrected. I have to say though, I find it harder to read. > > I see some unused code commented out in the spec file, but often that causes > > issues if the first character on a line after the # is a %. In general it is > > good practice to remove unused code from the spec file to aid readability > > and allow other packagers to help maintain the package. > > This is a easy fix, it is not a bloquer isue > Yep. > > I see that moving the themes to /usr/share/... hasn't happened, such that > > the package isn't FHS compliant - this really does need fixing. > > I need to refers to python-sphinx as the most similar package to mkdocs than > I can find and python-sphinx place theme files under > /usr/lib/python2.7/site-packages/sphinx/themes/ > > So I really thinks than move theme files to /usr/share it is not required > > See: > http://koji.fedoraproject.org/koji/ > rpminfo?fileStart=350&rpmID=6560137&fileOrder=name&buildrootOrder=- > id&buildrootStart=50#filelist > > Debian packaging also do not move the templates files: > https://packages.debian.org/source/sid/python-mkdocs > > Arch packging also do not do it: > https://aur.archlinux.org/packages/python-mkdocs/ > > The arch packaging it is not very good by the way :( That all may be true, but nonetheless, FHS compliance is a blocker (and sphinx should also be fixed). Data should go under /usr/share. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review