[Bug 1230963] Review Request: mkdocs - Python tool to create HTML documentation from markdown sources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1230963



--- Comment #22 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
The spec file changelog has been badly line wrapped such that the
version-release tag appears as the first entry - that needs fixing. You
generally seem to have an issue with line wrapping (as seen in other reviews) -
I suggest you turn line wrapping off in whatever editor you use as it is
wasting you a lot of time.

I see some unused code commented out in the spec file, but often that causes
issues if the first character on a line after the # is a %. In general it is
good practice to remove unused code from the spec file to aid readability and
allow other packagers to help maintain the package.

I see that moving the themes to /usr/share/... hasn't happened, such that the
package isn't FHS compliant - this really does need fixing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]